Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve responsive UI #86

Merged
merged 4 commits into from
Sep 10, 2024
Merged

refactor: improve responsive UI #86

merged 4 commits into from
Sep 10, 2024

Conversation

Aidosmf
Copy link
Member

@Aidosmf Aidosmf commented Aug 19, 2024

The header UI is broken after the changes from #80

Screenshot 2024-08-19 at 14 23 37

@Aidosmf Aidosmf requested a review from mbasaglia August 19, 2024 09:41
@Aidosmf Aidosmf self-assigned this Aug 19, 2024
@mbasaglia
Copy link
Member

The reason I added that was because at small widths, the page content scales in weird ways, we might need to add a more specific rule to fix it

@Aidosmf
Copy link
Member Author

Aidosmf commented Aug 19, 2024

@mbasaglia could you please share examples, of which pages width you would like to improve? I will improve it

@Aidosmf Aidosmf marked this pull request as draft August 19, 2024 11:57
@mbasaglia
Copy link
Member

I think the best example is the single page, if you reduce the width with dev tools, eventually the text becomes much smaller than the available area

@Aidosmf Aidosmf changed the title fix: header UI refactor: improve responsive UI Aug 19, 2024
@mbasaglia mbasaglia added this to the 1.0 milestone Aug 20, 2024
@Aidosmf Aidosmf marked this pull request as ready for review September 9, 2024 13:44
@Aidosmf Aidosmf merged commit 5b0b27d into main Sep 10, 2024
6 checks passed
@Aidosmf Aidosmf deleted the mf/fix-ui branch September 10, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants